fix(framework): Remove @novu/shared dependency temporarily #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR copied all the @novu/shared code directly into the @novu/framework package to eliminate a dependency that is causing ESM/CJS issues on @novu/framework. This is a temporary patch until we refactor @novu/shared to use strict TS and support ESM/CJS.
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@novu/client
@novu/framework
@novu/nest
@novu/headless
@novu/js
@novu/nextjs
@novu/notification-center
@novu/node
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
scopsy
reviewed
Dec 20, 2024
scopsy
approved these changes
Dec 20, 2024
Co-authored-by: Dima Grossman <[email protected]>
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
This PR copied all the
@novu/sharedcode directly into the @novu/framework package to eliminate a dependency that is causing ESM/CJS issues on@novu/framework.This is a temporary patch until we refactor @novu/shared to use strict TS and support ESM/CJS.
It should address:
-[] #6346