Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Crate with fixes #7367

Merged
merged 10 commits into from
Dec 24, 2024
Merged

fix(dashboard): Crate with fixes #7367

merged 10 commits into from
Dec 24, 2024

Conversation

SokratisVidros
Copy link
Contributor

What changed? Why was the change needed?

See commits

The following screenshots show the UI glitches this PR addresses

Screenshot 2024-12-24 at 12 13 43 Screenshot 2024-12-24 at 12 17 23 Screenshot 2024-12-24 at 13 21 29

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit bc47241
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/676ab7584743730008f66a16
😎 Deploy Preview https://deploy-preview-7367.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name Link
🔨 Latest commit bc47241
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/676ab75885bff5000858efaf

@SokratisVidros SokratisVidros changed the title Crate with fixes fix(dashboard): Crate with fixes Dec 24, 2024
>
Learn more <RiExternalLinkLine className="inline size-4" />
</Link>
<ExternalLink href="https://docs.novu.co/concepts/workflows">Learn more</ExternalLink>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

apps/dashboard/src/components/user-profile.tsx Outdated Show resolved Hide resolved
elements: {
formButtonPrimary: cn(buttonVariants({ variant: 'primary' })),
},
variables: {
fontSize: '14px !important',
},
}}
localization={CLERK_LOCALIZATION}
allowedRedirectOrigins={ALLOWED_REDIRECT_ORIGINS}
localization={{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlining gives us types in Intellisense ;)

@SokratisVidros SokratisVidros merged commit cee5ac3 into next Dec 24, 2024
26 of 34 checks passed
@SokratisVidros SokratisVidros deleted the crate_with_fixes branch December 24, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants