feat(api-service,dashboard): add step events.length variable #7601
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX,
tatarco,
djabarovgeorge and
desiprisg
LetItRock
commented
Jan 28, 2025
Comment on lines
+25
to
+30
| properties: { | ||
| // the length property is JS native property on arrays | ||
| length: { | ||
| type: 'number', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is the valid JSONSchema syntax. So here we define the length property on the events array. It will be available on arrays as it's JS native property on the arrays.
| @@ -54,7 +55,7 @@ const VariablesList = React.forwardRef<HTMLUListElement, VariablesListProps>( | |||
| }} | |||
| > | |||
| <Code2 className="text-feature size-3 min-w-3" /> | |||
| {option.label} | |||
| <TruncatedText>{option.label}</TruncatedText> | |||
There was a problem hiding this comment.
Fix for the long variable names, the truncated text will be shown in tip on hover
| @@ -46,6 +46,9 @@ export function parseStepVariables(schema: JSONSchemaDefinition): ParsedVariable | |||
| type: 'variable', | |||
| label: fullPath, | |||
| }); | |||
| if (value.properties) { | |||
| extractProperties({ type: 'object', properties: value.properties }, fullPath); | |||
There was a problem hiding this comment.
extract properties from the array type
BiswaViraj
reviewed
Jan 28, 2025
Comment on lines
105
to
107
| if (typeof skip === 'boolean') { | ||
| updateStepData.controlValues!.skip = null; | ||
| } |
There was a problem hiding this comment.
didn't update with latest next, will do that
SokratisVidros
approved these changes
Jan 28, 2025
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Add the step
steps.digest-step.events.lengthvariable for the digested events.Truncate the variables name in the dropdown.
Screenshots