feat(api-service): add create subscriber functionality with validation #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
changed the title
BiswaViraj
force-pushed
the
nv-5181-subscriber-creation-via-ui
branch
from
8259103 to
b41bf7b
Compare
ChmaraX
approved these changes
Feb 5, 2025
…g, improve documentation
…nd error handling
BiswaViraj
force-pushed
the
nv-5181-subscriber-creation-via-ui
branch
from
84aad68 to
56271bf
Compare
SokratisVidros
approved these changes
Feb 5, 2025
| @@ -0,0 +1,91 @@ | |||
| import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger'; | |||
apps/api/src/app/subscribers-v2/usecases/create-subscriber/create-subscriber.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/subscribers-v2/usecases/create-subscriber/create-subscriber.usecase.ts
Outdated
Show resolved
Hide resolved
| @@ -27,7 +27,7 @@ describe('Update Subscribers global preferences - /subscribers/:subscriberId/pre | |||
| }; | |||
|
|
|||
| try { | |||
| const firstResponse = await novuClient.subscribers.preferences.updateGlobal( | |||
There was a problem hiding this comment.
question: why do we have different data structure patterns?
above we have listLegacy and retrieveByLevelLegacy with suffix legacy but here we have nested object of legacy.
There was a problem hiding this comment.
I am not sure about that, it was already present before, after rebase the tests were failing so i just updated the e2e tests to use the available methods
BiswaViraj
added a commit
that referenced
this pull request
Feb 6, 2025
BiswaViraj
added a commit
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
create subscriber endpoint
E2E will be in a different PR
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer