update: Add parens to clarify order of operations when defaulting where

Credit: @iarna
npm · May 5, 2018 · 74bcdb8 · 74bcdb8
1 parent 3232699
commit 74bcdb8
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/update.js b/lib/update.js
@@ -57,7 +57,7 @@ function update_ (args) {
       // use the initial installation method (repo, tar, git) for updating
       if (url.parse(ww.req).protocol) ww.what = ww.req
 
-      const where = ww.dep.parent && ww.dep.parent.path || ww.dep.path
+      const where = (ww.dep.parent && ww.dep.parent.path) || ww.dep.path
       const isTransitive = !(ww.dep.requiredBy || []).some((p) => p.isTop)
       const key = where + ':' + String(isTransitive)
       if (!toInstall[key]) toInstall[key] = {where: where, opts: {saveOnlyLock: isTransitive}, what: []}