-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add in-range #3397
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,20 @@ cat 1.0.0 1.0.1 1.0.1 node_modules/cat tap-testdir-outdated-should | |
chai 1.0.0 1.0.1 1.0.1 node_modules/chai tap-testdir-outdated-should-display-outdated-deps | ||
dog 1.0.1 1.0.1 2.0.0 node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
theta MISSING 1.0.1 1.0.1 - tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --in-range > must match snapshot 1`] = ` | ||
|
||
Package Current Wanted Latest Location Depended by | ||
cat 1.0.0 1.0.1 1.0.1 node_modules/cat tap-testdir-outdated-should-display-outdated-deps | ||
chai 1.0.0 1.0.1 1.0.1 node_modules/chai tap-testdir-outdated-should-display-outdated-deps | ||
theta MISSING 1.0.1 1.0.1 - tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --json --long > must match snapshot 1`] = ` | ||
|
@@ -89,6 +103,18 @@ cat 1.0.0 1.0.1 1.0.1 node_modules/cat tap-testdir-outdated-should | |
chai 1.0.0 1.0.1 1.0.1 node_modules/chai tap-testdir-outdated-should-display-outdated-deps peerDependencies | ||
dog 1.0.1 1.0.1 2.0.0 node_modules/dog tap-testdir-outdated-should-display-outdated-deps dependencies | ||
theta MISSING 1.0.1 1.0.1 - tap-testdir-outdated-should-display-outdated-deps dependencies | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --no-in-range > must match snapshot 1`] = ` | ||
|
||
Package Current Wanted Latest Location Depended by | ||
dog 1.0.1 1.0.1 2.0.0 node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=dev --omit=peer > must match snapshot 1`] = ` | ||
|
@@ -97,6 +123,9 @@ exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=d | |
[31mcat[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/cat tap-testdir-outdated-should-display-outdated-deps | ||
[33mdog[39m 1.0.1 [32m1.0.1[39m [35m2.0.0[39m node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
[31mtheta[39m MISSING [32m1.0.1[39m [35m1.0.1[39m - tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=dev > must match snapshot 1`] = ` | ||
|
@@ -106,6 +135,9 @@ exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=d | |
[31mchai[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/chai tap-testdir-outdated-should-display-outdated-deps | ||
[33mdog[39m 1.0.1 [32m1.0.1[39m [35m2.0.0[39m node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
[31mtheta[39m MISSING [32m1.0.1[39m [35m1.0.1[39m - tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=prod > must match snapshot 1`] = ` | ||
|
@@ -114,6 +146,9 @@ exports[`test/lib/outdated.js TAP should display outdated deps outdated --omit=p | |
[31mcat[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/cat tap-testdir-outdated-should-display-outdated-deps | ||
[31mchai[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/chai tap-testdir-outdated-should-display-outdated-deps | ||
[33mdog[39m 1.0.1 [32m1.0.1[39m [35m2.0.0[39m node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated --parseable --long > must match snapshot 1`] = ` | ||
|
@@ -139,18 +174,27 @@ exports[`test/lib/outdated.js TAP should display outdated deps outdated > must m | |
[31mchai[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/chai tap-testdir-outdated-should-display-outdated-deps | ||
[33mdog[39m 1.0.1 [32m1.0.1[39m [35m2.0.0[39m node_modules/dog tap-testdir-outdated-should-display-outdated-deps | ||
[31mtheta[39m MISSING [32m1.0.1[39m [35m1.0.1[39m - tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated global > must match snapshot 1`] = ` | ||
|
||
Package Current Wanted Latest Location Depended by | ||
cat 1.0.0 1.0.1 1.0.1 node_modules/cat global | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP should display outdated deps outdated specific dep > must match snapshot 1`] = ` | ||
|
||
Package Current Wanted Latest Location Depended by | ||
cat 1.0.0 1.0.1 1.0.1 node_modules/cat tap-testdir-outdated-should-display-outdated-deps | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display all dependencies 1`] = ` | ||
|
@@ -160,6 +204,9 @@ cat 1.0.0 1.0.1 1.0.1 node_modules/cat [email protected] | |
chai 1.0.0 1.0.1 1.0.1 node_modules/chai foo | ||
dog 1.0.1 1.0.1 2.0.0 node_modules/dog tap-testdir-outdated-workspaces | ||
theta MISSING 1.0.1 1.0.1 - [email protected] | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display json results filtered by ws 1`] = ` | ||
|
@@ -179,13 +226,19 @@ exports[`test/lib/outdated.js TAP workspaces > should display missing deps when | |
|
||
Package Current Wanted Latest Location Depended by | ||
theta MISSING 1.0.1 1.0.1 - [email protected] | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display nested deps when filtering by ws and using --all 1`] = ` | ||
|
||
Package Current Wanted Latest Location Depended by | ||
cat 1.0.0 1.0.1 1.0.1 node_modules/cat [email protected] | ||
chai 1.0.0 1.0.1 1.0.1 node_modules/chai foo | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display no results if ws has no deps to display 1`] = ` | ||
|
@@ -201,6 +254,9 @@ exports[`test/lib/outdated.js TAP workspaces > should display results filtered b | |
|
||
Package Current Wanted Latest Location Depended by | ||
cat 1.0.0 1.0.1 1.0.1 node_modules/cat [email protected] | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display ws outdated deps human output 1`] = ` | ||
|
@@ -209,6 +265,9 @@ Package Current Wanted Latest Location Depended by | |
cat 1.0.0 1.0.1 1.0.1 node_modules/cat [email protected] | ||
dog 1.0.1 1.0.1 2.0.0 node_modules/dog tap-testdir-outdated-workspaces | ||
theta MISSING 1.0.1 1.0.1 - [email protected] | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` | ||
|
||
exports[`test/lib/outdated.js TAP workspaces > should display ws outdated deps json output 1`] = ` | ||
|
@@ -249,4 +308,7 @@ exports[`test/lib/outdated.js TAP workspaces > should highlight ws in dependend | |
[31mcat[39m 1.0.0 [32m1.0.1[39m [35m1.0.1[39m node_modules/cat [[email protected][39m | ||
[33mdog[39m 1.0.1 [32m1.0.1[39m [35m2.0.0[39m node_modules/dog tap-testdir-outdated-workspaces | ||
[31mtheta[39m MISSING [32m1.0.1[39m [35m1.0.1[39m - [[email protected][39m | ||
|
||
For more info on why dependencies have been installed at their current version, see: | ||
npm explain <pkg> | ||
` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so with these options, how do i override
NPM_CONFIG_IN_RANGE=false npm outdated
(or true)? do i have to do--in-range=null
?Generally a boolean isn't a great choice when there's three options, so perhaps an enum would be clearer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ljharb see the discussion on the if statements above, it is as you say checking for the default
null
vs an explicit true or false. I agree it's not ideal and that discussion is why this PR went back to draft status to be discussed and solved as part of a better solution that letsnpm update --dry-run
solve the "What can be updated problem" first.