feat: sort and quote yarn lock keys according to yarn rules #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
changed the title
wraithgar
force-pushed
the
update-yarn-lock-properly
branch
from
65d930a to
9f7ebbf
Compare
wraithgar
changed the title
wraithgar
force-pushed
the
update-yarn-lock-properly
branch
from
9f7ebbf to
1c68058
Compare
wraithgar
force-pushed
the
update-yarn-lock-properly
branch
from
1c68058 to
eae8552
Compare
lukekarrys
approved these changes
Oct 19, 2022
|
@wraithgar I see this was released, but the yarn-lock file on latest has none of the changes or commits. Was it removed? |
|
9.0.0 is not tagged as latest yet |
|
Re:tagged as latest - The strategy is explained here
@wraithgar Are you sure it is in the source, though? Visiting 64a19d0 yields the warning
Not sure if this relates to the tagging. |
|
You're right, something funky happened here during the release, cc @lukekarrys |
|
I had the branch locally still, pushed and made a pr #5751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the logic used for sorting keys when writing yarn.lock to be more in line with Yarn's own rules, avoiding unnecessary diffs and confusion.
This adds a commit to #5659
Please squash