This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
feat: add walk up dir lookup to satisfy local bins #2
+129
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
This is fine, but we should pull out the "walk up the path adding nodE_modules/.bin to things" into a standalone package that both run-script and libnpmexec use, and we should at least have the ability to set a root dir that we don't allow it to walk up past.
Rough cut at a thing like that: https://gist.github.com/isaacs/3db535658c1cb0976126159d63286423
Currently @npmcli/run-script already supports this walk up lookup logic that allows any nested folder to use a bin that is located inside a node_modules/.bin folder higher in the directory tree. This commit adds the same logic from: https://github.com/npm/run-script/blob/47a4d539fb07220e7215cc0e482683b76407ef9b/lib/set-path.js#L24-L28 to libnpmexec so that users may use a binary from a dependency of a nested workspace in the context of that workspaces' folder. Fixes: npm/cli#2826
ruyadorno
force-pushed
the
walk-up-local-bin-lookup
branch
from
c6cde1d to
82a72ae
Compare
|
did the first pass aligning the implementation here to use walk-up-path, let's follow up with the module refactor later 😊 but this should be good to land now |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
@npmcli/run-scriptalready supports this walk up lookup logicthat allows any nested folder to use a bin that is located inside a
node_modules/.binfolder higher in the directory tree.This commit adds the same logic from:
https://github.com/npm/run-script/blob/47a4d539fb07220e7215cc0e482683b76407ef9b/lib/set-path.js#L24-L28
to libnpmexec so that users may use a binary from a dependency of a
nested workspace in the context of that workspace's folder.
References
Fixes: npm/cli#2826