Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify comment about obsolete prefixes #749

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Nov 28, 2024

Adds an explanation why the "=" and "v" prefixes should not be used anymore.

Adds an explanation why the "=" and "v" prefixes should not be used anymore.
@mbtools mbtools requested a review from a team as a code owner November 28, 2024 05:29
README.md Show resolved Hide resolved
@wraithgar
Copy link
Member

This now says two contradictory things.

  • v is stripped
  • v is kept

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jordan Harband <[email protected]>
@wraithgar wraithgar changed the title chore: clarify comment about obsolete prefixes docs: clarify comment about obsolete prefixes Dec 2, 2024
@wraithgar
Copy link
Member

Gonna land this but won't publish a new version until another change besides this one comes along.

@wraithgar wraithgar merged commit 868d4bb into npm:main Dec 4, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
@mbtools mbtools deleted the patch-1 branch December 4, 2024 16:35
wraithgar pushed a commit that referenced this pull request Jan 29, 2025
🤖 I have created a release *beep* *boop*
---


## [7.7.0](v7.6.3...v7.7.0)
(2025-01-29)
### Features
*
[`0864b3c`](0864b3c)
[#753](#753) add "release" inc
type (#753) (@mbtools)
### Bug Fixes
*
[`d588e37`](d588e37)
[#755](#755) diff: fix prerelease
to stable version diff logic (#755) (@eminberkayd, berkay.daglar)
*
[`8a34bde`](8a34bde)
[#754](#754) add identifier
validation to `inc()` (#754) (@mbtools)
### Documentation
*
[`67e5478`](67e5478)
[#756](#756) readme: added
missing period for consistency (#756) (@shaymolcho)
*
[`868d4bb`](868d4bb)
[#749](#749) clarify comment
about obsolete prefixes (#749) (@mbtools, @ljharb)
### Chores
*
[`145c554`](145c554)
[#741](#741) bump
@npmcli/eslint-config from 4.0.5 to 5.0.0 (@dependabot[bot])
*
[`753e02b`](753e02b)
[#747](#747) bump
@npmcli/template-oss from 4.23.3 to 4.23.4 (#747) (@dependabot[bot],
@npm-cli-bot)
*
[`0b812d5`](0b812d5)
[#744](#744) postinstall for
dependabot template-oss PR (@hashtagchris)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants