Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install flag for dev dependencies #14

Merged
merged 1 commit into from
May 11, 2018
Merged

Fix install flag for dev dependencies #14

merged 1 commit into from
May 11, 2018

Conversation

phil-r
Copy link
Contributor

@phil-r phil-r commented May 11, 2018

According to docs the correct flag for dev dependencies is --save-dev, not --dev.

Running the code with --dev results in the following error:

npm WARN install Usage of the `--dev` option is deprecated. Use `--only=dev` instead.

zkat
zkat approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! This was a thing we noticed that we hadn't gotten around to fixing. Much happier to have you send a PR! Thanks a bunch!

@zkat zkat merged commit 30e5f30 into npm:latest May 11, 2018
@phil-r
Copy link
Contributor Author

phil-r commented May 12, 2018

🎉 No problem ;)

@matthewberryman matthewberryman mentioned this pull request May 12, 2018
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-r @zkat