Increase default timeout value from 30s to 5m #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: #26 Re: npm/cli#1151 The previous default of 30s was too small for lots of users, causing problems when they attempt to download large objects from the npm registry. Bump up the default timeout to 5m. TODO: add a `--fetch-timeout` option on the CLI to explicitly set `timeout` in the npm.flatOptions object passed to all dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #26
Re: npm/cli#1151
The previous default of 30s was too small for lots of users, causing
problems when they attempt to download large objects from the npm
registry.
Bump up the default timeout to 5m.
TODO: add a
--fetch-timeoutoption on the CLI to explicitly settimeoutin the npm.flatOptions object passed to all dependencies.