Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

fix(notice): change blue foreground to cyan #92

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

wraithgar
Copy link
Member

It is very difficult to see.

Credit: @koddsson #56

@wraithgar wraithgar requested a review from a team as a code owner February 9, 2022 18:18
@ruyadorno
Copy link

Here is a preview using Solarized dark colorscheme:

Before -----------------------------------------------------------| After
Screen Shot 2022-02-09 at 1 16 12 PM

I don't particularly dislike it but I guess the blue looked good in colorschemes in which it was visible, happy to have that tradeoff to make everyone else more comfortable.

The only point I raised in an internal chat is wether the yellow might be seen as a Warning, makes me wonder if there's any other good visible color we could pick from.

@ruyadorno
Copy link

ruyadorno commented Feb 9, 2022

exploring the ANSI color options, it looks like a more sensible (and less dramatic) change would be from blue -> cyan, it def should be way more readable in a dark background. Here it how it looks like in a few color scheme:

Solarized dark colorscheme
Screen Shot 2022-02-09 at 1 27 17 PM


iTerm2 Dark Background

Screen Shot 2022-02-09 at 1 30 01 PM


iTerm2 Tango Dark
Screen Shot 2022-02-09 at 1 29 39 PM

It is very difficult to see.

Credit: @koddsson #56
@wraithgar wraithgar changed the title fix(notice): stop using blue on black fix(notice): change blue foreground to cyan Feb 9, 2022
Copy link

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 👍 thank you @wraithgar 🥳

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants