fix: node 18.16.0 以降で発生する unzipper の誤動作対策 #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou029w
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
コードに関しては全く問題ないように見えます 👍
参考文献: https://github.com/ZJONSSON/node-unzipper#parse-zip-file-contents
(問題の再現・動作確認はまだ私はできていないので @ties-makimura さんに任せます。)
|
node v18.17.0 の環境で確認して，一括登録したビデオが問題なく再生されるの確認できました． また，一括登録前後でのビデオのハッシュ値も一致していました． |
This was referenced Aug 3, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #925
unzipper を最新の 0.10.14 に更新してみましたが、動作は変わりませんでした。
unzipper の Extract ではなく Parse を使って自分でファイルを書くと問題が発生しません。