ci(build): handle PDM v2.9.0 change in API #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDM v2.9.0 changed how the `pdm install --no-default` command worked, as it now installs dev dependencies, and it runs a [PEP 517][] build. In order to get the old behaviour, where it only installs dev dependencies (without the build), we now need to add a `--no-self` option. [PEP 517]: https://peps.python.org/pep-0517/ See: pdm-project/pdm#2230
This was referenced Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDM v2.9.0 changed how the
pdm install --no-defaultcommand worked, as it now installs dev dependencies, and it runs a PEP 517 build. This means that our CI is now failing, see https://github.com/nqminds/nqm-irimager/actions/runs/6072678770/job/16473094068 for an example.In order to get the old behaviour, where it only installs dev dependencies (without the build), we now need to add a
--no-selfoption.See PDM bug report: pdm-project/pdm#2230