-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1004: beamdp axis labels are confusing #1170
Fix #1004: beamdp axis labels are confusing #1170
Conversation
@blakewalters I agree with you about slash notation for units, for it becomes quite confusing, as you said, when the units themselves involve a quotient. I find that However, the SI Brochure Section 5.4 is quite definitive in its recommendation for Rules and style conventions for expressing values of quantities:
So you and I will probably just have to get used to it? |
I fixed all the other occurrences of erroneous flags |
Commits should be squashed before merging. |
Revert changes to units in the output of egs_fluence_scoring and cavity. This was needed to avoid compiler errors when using newer compilers.
Revert changes to units in the output of egs_fluence_scoring and cavity. This was needed to avoid compiler errors when using newer compilers.
Revert changes to units in the output of egs_fluence_scoring and cavity. This was needed to avoid compiler errors when using newer compilers.
Addresses #1004.
Note: I find our method for specifying axis units in beamdp using a backslash in front of the unit (i.e., '/unit') confusing, especially for quantities which may also have a unit in the denominator (e.g., '/MeV cm^-2'). I wonder if we should move to just using brackets instead.