-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] USB support #133
Closed
Closed
[WIP] USB support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+10
/// Writes `val` to `addr`. Used to apply Errata workarounds. | ||
unsafe fn poke(addr: u32, val: u32) { | ||
*(addr as *mut u32) = val; | ||
} | ||
|
||
/// Reads 32 bits from `addr`. | ||
unsafe fn peek(addr: u32) -> u32 { | ||
*(addr as *mut u32) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be volatile operations ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I thought I made them volatile...
Closed
Closing in favor of #144 |
wez
added a commit
that referenced
this pull request
Feb 14, 2021
Fixes compilation by pointing to current versions and takes in @unrelentingtech's fork of usb-device and suggestion in #144 (review) I folded in the hello world portion from japaric's PR summary text. refs: rust-embedded-community/usb-device#51 closes: #144
Disasm
pushed a commit
to Disasm/nrf-hal
that referenced
this pull request
Feb 17, 2021
Fixes compilation by pointing to current versions and takes in @unrelentingtech's fork of usb-device and suggestion in nrf-rs#144 (review) I folded in the hello world portion from japaric's PR summary text. refs: rust-embedded-community/usb-device#51 closes: nrf-rs#144
fnafnio
pushed a commit
to fnafnio/nrf-hal
that referenced
this pull request
May 12, 2021
Fixes compilation by pointing to current versions and takes in @unrelentingtech's fork of usb-device and suggestion in nrf-rs#144 (review) I folded in the hello world portion from japaric's PR summary text. refs: rust-embedded-community/usb-device#51 closes: nrf-rs#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not managed to get this to enumerate yet, but it tries. Also had to work around an erratum that just makes the peripheral Not Work ™️ unless some magic values are written to magic addresses.