Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop reexporting the PAC under target #172

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Stop reexporting the PAC under target #172

merged 2 commits into from
Jul 11, 2020

Conversation

jonas-schievink
Copy link
Contributor

Builds on #171

Now we only have a single reexport of the PAC, called pac.

The HAL shims have already called it "pac". Move the common HAL over to
that too.
@Yatekii
Copy link
Contributor

Yatekii commented Jul 11, 2020

Is there a reasoning why it can't be called target anymore? I have neither preference but I'm curious. Also maybe we should include an alias to target still and add a deprecation message, such that it doesn't just explode for users.

@jonas-schievink
Copy link
Contributor Author

Mainly because pac does the same thing as target but has a much clearer name. I'm planning to write a changelog so users can be informed of the change there. Since migrating is very mechanical we shouldn't need a migration period.

@Yatekii
Copy link
Contributor

Yatekii commented Jul 11, 2020

Ok, this is ok for me then :) I guess it's really much clearer :)

@jonas-schievink jonas-schievink merged commit 619bee7 into nrf-rs:master Jul 11, 2020
@jonas-schievink jonas-schievink deleted the no-target branch July 11, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants