Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COMP module #189

Merged
merged 10 commits into from
Aug 2, 2020
Merged

Add COMP module #189

merged 10 commits into from
Aug 2, 2020

Conversation

kalkyl
Copy link
Contributor

@kalkyl kalkyl commented Aug 1, 2020

Added a HAL module for the COMP analog comparator peripheral.
The comparator compares an input voltage (Vin) against a second input voltage (Vref).
Vin can be derived from an analog input pin (AIN0-AIN7).
Vref can be derived from multiple sources depending on the operation mode of the comparator.
Tested on NRF52840-DK

Demo (nRF52840):
https://github.com/kalkyl/nrf-hal/blob/comp/examples/comp-demo/src/main.rs

Copy link
Member

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@jamesmunns
Copy link
Member

Merging manually due to false CI failures

@jamesmunns jamesmunns merged commit 833bbcf into nrf-rs:master Aug 2, 2020
@kalkyl kalkyl deleted the comp branch September 4, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants