Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Embed.toml of all examples to new defaults #229

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

andresovela
Copy link
Contributor

No description provided.

Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the long term, it seems to me that we might want to get rid of these files entirely, since this is a lot of churn, and they contain a lot of info that isn't very relevant.

@jonas-schievink jonas-schievink merged commit 6fa2576 into nrf-rs:master Sep 28, 2020
@Yatekii
Copy link
Contributor

Yatekii commented Sep 28, 2020

Yeah, people mostly copy the entire file. It is sufficient to just set the bits one needs different from the default (for example the chip). All the other config flags will default to a sane setting automatically.
so we can get rid of 95% of the contents :)
Nobody is bothered by the GDB scripts etc either, so I don't see why this would be an issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants