Add readme documentation for demos #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
kalkyl
reviewed
Oct 9, 2020
|
Thanks Henrik! |
jonas-schievink
suggested changes
Nov 17, 2020
Co-authored-by: Henrik Alsér <[email protected]>
ninjasource
force-pushed
the
readme-demo-docs
branch
from
4ba626f to
5a6fec4
Compare
thejpster
approved these changes
May 19, 2021
|
@jonas-schievink are you content to clear your blocking bit on this now? |
jonas-schievink
approved these changes
May 19, 2021
|
bors r+ |
|
Build succeeded: |
|
Hi Jonas and Jonathan, thanks for the approval. I "thought" that I addressed all the blocking things but I probably didn't click the right buttons for the PR to be handed over, my apologies! If there is anything still outstanding or things have gotten out of date since November 2020 I'd be happy to fix them in another PR. Just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've recently worked through all the demos and took notes as I was going. I thought it may be useful to add those notes to this repo if appropriate. I'm not sure if this is the correct place to put them but adding a
README.mdfile to the examples folder confuses cargo builds for some reason. I hope that this will be useful as I was not familiar with all the acronyms in the project and I think that newcomers will find this quick reference useful too.