Enables PWM for the nRF9160 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntc
force-pushed
the
enable-pwm
branch
2 times, most recently
from
411e000 to
500f660
Compare
Without it, we can't have blinky as its RGB LEDs require PWM! This PR assumes unsecured peripheral access. I'm thinking that in future we might introduce a "Secured" feature perhaps.
Merged
|
Works on my nRF9160-DK. It might be worth a second PR just confirming which boards this examples are designed to run on. |
|
I also hacked it to blink at varying intensity levels to check the PWM worked correctly. We should note that on an nRF9160-DK maximum duty turns the LED off, and 0 turns the LED on (they must have an inverter in there, or they switch the ground not the Vcc). |
|
@bors r+ |
|
bors r=jonathanpallant |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it, we can't have blinky on the Thingy:91 as its RGB LEDs require PWM!
This PR assumes just unsecured peripheral access for now.
I've also included a new
pwm-blinky-demoand ensure that this and the originalpwm-demoare included with thextasktests. Additionally, thepwm-blinky-demois tested for the nRF9160 target.Tested on an nRF9160-dk via the probe-rs/embed tool. The result from
cargo embed:cc @kalkyl