Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PWM EasyDMA max length #313

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix PWM EasyDMA max length #313

merged 1 commit into from
May 10, 2021

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented May 10, 2021

  1. The max length is 0x7FFF, not 0x8000 (1<<15). The latter already doesn't fit in 15 bits.
  2. The max length is in duty value count, not in bytes, so there's no need to divide by sizeof(u16)

I have verified the max length is 15 bits on all chips.

@Dirbaio
Fix PWM EasyDMA max length
ea3af5b 
1. The max length is 0x7FFF, not 0x8000 (1<<15). The latter already doesn't fit in 15 bits.
2. The max length is in duty value count, not in bytes, so there's no need to divide by sizeof(u16)

I have verified the max length is 15 bits on all chips.
Yatekii
Yatekii approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented May 10, 2021

Build succeeded:

@bors bors bot merged commit 1c76cbe into nrf-rs:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @Yatekii