-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified how pins are return in free
calls
#372
Conversation
de81a86
to
e3a7b7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be beneficial to add a free
method that only returns the peripheral, for efficiency (the added volatile reads add to code size). Presumably users would almost always want the pins back though?
If there should be a free without the pins, to me it does not make sense to not get back all the hardware that was used. |
There, it should be ready for a re-review now @jonas-schievink |
16aa04c
to
902650b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
bors r+ |
Build succeeded: |
Hi,
I unified so pins are returned the same for all peripherals.