Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zigbee: Add light switch sample #2226

Merged
merged 1 commit into from
May 22, 2020
Merged

zigbee: Add light switch sample #2226

merged 1 commit into from
May 22, 2020

Conversation

mariuszpos
Copy link
Contributor

Add Zigbee light switch sample.
This PR depends on:
#2208

@CLAassistant
Copy link

CLAassistant commented May 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mariuszpos mariuszpos marked this pull request as draft May 11, 2020 07:44
rlubos
rlubos reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess some documentation will be added as well later?

samples/zigbee/light_switch/src/main.c Outdated Show resolved Hide resolved
samples/zigbee/light_switch/src/main.c Outdated Show resolved Hide resolved
samples/zigbee/light_switch/src/main.c Outdated Show resolved Hide resolved
samples/zigbee/light_switch/include/zb_mem_config_custom.h Outdated Show resolved Hide resolved
samples/zigbee/light_switch/app.overlay Outdated Show resolved Hide resolved
samples/zigbee/light_switch/CMakeLists.txt Outdated Show resolved Hide resolved
@wbober
Copy link
Contributor

wbober commented May 13, 2020

I guess some documentation will be added as well later?

@mariuszpos what about docs? It should be in this PR.

@lemrey lemrey self-requested a review May 13, 2020 12:06
@greg-fer
Copy link
Contributor

Documentation is available here: https://projecttools.nordicsemi.no/bitbucket/projects/KRKNWK/repos/fw-nrfconnect-nrf/pull-requests/2/overview

The .rst file was deleted when the PR was declined.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 14, 2020 •
edited
Loading

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

@mariuszpos mariuszpos marked this pull request as ready for review May 14, 2020 13:40
@mariuszpos mariuszpos requested a review from ru-fu as a code owner May 14, 2020 13:40
@ru-fu ru-fu requested a review from greg-fer May 14, 2020 13:55
@ru-fu ru-fu added the doc-required PR must not be merged without tech writer approval. label May 14, 2020
@greg-fer
Copy link
Contributor

Can we wait for #2208 to be merged and rebase? This would solve the need for removing cross-links for merge and having to add them again later on.

@wbober wbober mentioned this pull request May 18, 2020
Merged
rlubos
rlubos reviewed May 20, 2020
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

samples/zigbee/light_switch/src/main.c Show resolved Hide resolved
samples/zigbee/light_switch/src/main.c Outdated Show resolved Hide resolved
@mariuszpos mariuszpos requested review from rlubos and wbober May 20, 2020 08:39
rlubos
rlubos approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

wbober
wbober requested changes May 22, 2020
View reviewed changes
Copy link
Contributor

@wbober wbober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation in this PR isn't accurate. There is no ZCL groups, SED, BLE etc. These will come in separate PRs.

greg-fer
greg-fer approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked locally. Approving, but please squash my changes.

samples: zigbee: Add light switch sample
dce7b13 
Add light switch sample

Signed-off-by: Mariusz Poslinski <[email protected]>
@rlubos
Copy link
Contributor

rlubos commented May 22, 2020

Are the changes in other samples and zigbee_helper intentional?

@mariuszpos
Copy link
Contributor Author

mariuszpos commented May 22, 2020 •
edited
Loading

Yes. In zigbee_helper was compilation warning which I fixed. Other examples required changes to the documentation for the switch.

@mariuszpos mariuszpos closed this May 22, 2020
@mariuszpos mariuszpos reopened this May 22, 2020
@rlubos rlubos merged commit faa013a into nrfconnect:master May 22, 2020
@mariuszpos mariuszpos deleted the add_samples_zigbee_light_switch branch May 22, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbober wbober wbober requested changes

@greg-fer greg-fer greg-fer approved these changes

@rlubos rlubos rlubos approved these changes

@lemrey lemrey Awaiting requested review from lemrey

@ru-fu ru-fu Awaiting requested review from ru-fu

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mariuszpos @CLAassistant @wbober @greg-fer @NordicBuilder @rlubos @ru-fu