[nrf noup] samples: mgmt: mcumgr: smp_svr: Add nrf5340dk-optimised sample #2269
Conversation
There was a problem hiding this comment.
Multiple board configuration/overlay files was added in the sample's sysbuild/mcuboot/boards directory as well (not only nRF540dk).
I see that many of the can be involved into the build configuration as I'm recognizing them as their copies from MCUBoot's repository.
- What intention behind that?
- Why 3-rd party board files are added?
- Should we remove original files from MCUboot's repository?
So that this sample can be used with any (nordic-based) board still, as the files in MCUboot will not be used
As above, only nordic-based boards are added
No |
|
Would add that this is only need due to, yet again, partition manager |
There was a problem hiding this comment.
nit: nrf54l15PDK can be removed, only DK is now supported
nit2: do we need pm_static files? Partition Manager should generate pm_static
and it is not fine that we need to copy all those configs from MCUboot repo when using sysbuild. As I remember, for child images those configs were taken as a default parameters, and overwritten by sample configs, now if we have any file/folder in sysbuild dir we must copy defaults to the project dir :(
There was a problem hiding this comment.
Will we can avoid many of *.conf files copies If this file will be removed?
There was a problem hiding this comment.
Have reworked PR, all these files are now gone
nordicjm
force-pushed
the
nrf53smp
branch
2 times, most recently
from
774c9de to
caf4f06
Compare
jukkar
requested review from
anangl,
carlescufi,
nordic-krch and
a team
as code owners
|
@nordicjm Can you rebase this? |
|
@nordicjm Can be merged. |
|
@nrfconnect/ncs-test-leads Please give tick. |
CI is red. Please take a look on DFU tests. |
…mple Adds a configuration to this sample that is optimised for testing/usage with the nRF5340 which enables the Bluetooth transport, enables most management groups, has a static partition manager file with secondary partitions on QSPI flash, configures MCUboot in overwrite only mode with network core update support Signed-off-by: Jamie McCrae <[email protected]>
Adds a configuration to this sample that is optimised for testing/usage with the nRF5340 which enables the Bluetooth transport, enables most management groups, has a static partition manager file with secondary partitions on QSPI flash, configures MCUboot in overwrite only mode with network core update support