fix: Hashicorp Vault PKI doesn't fail with due to KeyPair mismatch (k…

…edacore#6029) Signed-off-by: Jorge Turrado <[email protected]> Signed-off-by: michael pechner <[email protected]>
nrichardson-akasa · Nov 29, 2024 · 95b8f24 · 95b8f24
1 parent 2150b61
commit 95b8f24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -71,7 +71,7 @@ Here is an overview of all new **experimental** features:
 
 ### Fixes
 
-- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX))
+- **General**: Hashicorp Vault PKI doesn't fail with due to KeyPair mismatch ([#6028](https://github.com/kedacore/keda/issues/6028))
 
 ### Deprecations
 

diff --git a/pkg/scaling/resolver/hashicorpvault_handler.go b/pkg/scaling/resolver/hashicorpvault_handler.go
@@ -277,7 +277,7 @@ func (vh *HashicorpVaultHandler) getSecretValue(secret *kedav1alpha1.VaultSecret
 type SecretGroup struct {
 	path         string
 	secretType   kedav1alpha1.VaultSecretType
-	vaultPkiData *kedav1alpha1.VaultPkiData
+	vaultPkiData kedav1alpha1.VaultPkiData
 }
 
 // fetchSecret returns the vaultSecret at a given vault path. If the secret is a pki, then the secret will use the
@@ -314,15 +314,15 @@ func (vh *HashicorpVaultHandler) ResolveSecrets(secrets []kedav1alpha1.VaultSecr
 	grouped := make(map[SecretGroup][]kedav1alpha1.VaultSecret)
 	vaultSecrets := make(map[SecretGroup]*vaultapi.Secret)
 	for _, e := range secrets {
-		group := SecretGroup{secretType: e.Type, path: e.Path, vaultPkiData: &e.PkiData}
+		group := SecretGroup{secretType: e.Type, path: e.Path, vaultPkiData: e.PkiData}
 		if _, ok := grouped[group]; !ok {
 			grouped[group] = make([]kedav1alpha1.VaultSecret, 0)
 		}
 		grouped[group] = append(grouped[group], e)
 	}
 	// For each group fetch the secret from vault
 	for group := range grouped {
-		vaultSecret, err := vh.fetchSecret(group.secretType, group.path, group.vaultPkiData)
+		vaultSecret, err := vh.fetchSecret(group.secretType, group.path, &group.vaultPkiData)
 		if err != nil {
 			// could not fetch secret, skipping group
 			continue