changed all commands from redisReplyReader to redisReader #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the hiredis documents and see that the main change to 0.14.0 from 0.13.3 is that some commands were changed from redisReplyReader* to redisReader*. I made this simple change to the *.c file, compiled it for armv7h, installed hiredis 0.14.0, installed the compiled php-phpiredis-git and now it works. I was reading through the docs for the upcoming updates and do not think I know enough to adapt this to the upcoming hiredis 1.0.0 as there are more changes that I do not fully understand, so I may not be able to help on the next update, but for now, this seems to work.
https://github.com/redis/hiredis/blob/master/CHANGELOG.md