Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BQSqlFrag.TableRef #120

Merged
merged 5 commits into from
Jul 17, 2023
Merged

New BQSqlFrag.TableRef #120

merged 5 commits into from
Jul 17, 2023

Conversation

HenningKoller
Copy link
Contributor

Use view partitionId to assert partition on underlying TableRef, if view is date partitioned.

Use view partitionId to assert partition on underlying TableRef, if view is date partitioned.
@HenningKoller HenningKoller requested a review from hamnis July 12, 2023 07:33
@HenningKoller
Copy link
Contributor Author

Nytt forslag.
Nå styrer bruken av viewet hvordan vi finner PartitionId for tabellene viewet bruker. Så hvis man asserter en partition på viewet asserter vi etter samme partition på tabellene under.

hamnis
hamnis previously approved these changes Jul 12, 2023
Copy link
Contributor

@hamnis hamnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@HenningKoller HenningKoller marked this pull request as ready for review July 12, 2023 10:39
List(fill.tableDef.withTableType(partitionType).assertPartition(partitionRef.partition))
case (_, _) => List(fill.tableDef.unpartitioned.assertPartition)
}
List(fill.tableDef.unpartitioned.assertPartition)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

denne returneres alltid. Er det det du vil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope!

@hamnis hamnis self-requested a review July 13, 2023 10:01
@hamnis hamnis dismissed their stale review July 13, 2023 10:02

new changes

Copy link
Contributor

@hamnis hamnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some duplicated code, but we can fix that later

@HenningKoller HenningKoller merged commit 8bb5d5f into main Jul 17, 2023
@HenningKoller HenningKoller deleted the bqsqlfrag-tableref branch July 17, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants