Feature/Table valued functions #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
reviewed
Sep 15, 2023
ingarabr
force-pushed
the
feature/tvf
branch
3 times, most recently
from
6ab8b55 to
81b6083
Compare
ingarabr
commented
Nov 8, 2023
ingarabr
force-pushed
the
feature/tvf
branch
3 times, most recently
from
48a6946 to
be7e6fe
Compare
ingarabr
commented
Nov 14, 2023
hamnis
reviewed
Nov 14, 2023
hamnis
reviewed
Nov 14, 2023
ingarabr
force-pushed
the
feature/tvf
branch
3 times, most recently
from
b5e1bbe to
d2b723d
Compare
hamnis
reviewed
Nov 15, 2023
ingarabr
force-pushed
the
feature/tvf
branch
from
d2b723d to
368c944
Compare
hamnis
approved these changes
Nov 17, 2023
moved Params from UDF to Routines for readability
- added table value functions (tvf) - udf and tvf are both routines, so they are consolidated under the same concept, `Routine`
The check is a bit different from table and views. It has to verify that the schema matches and the params. The schema tests is done through a CTE and the parameters through a UDF that always return true. The query CTE body needs to include a reference to both of them.
Done the dame way as other fragments however we define the tvf parameters at the top of the fragment.
ingarabr
force-pushed
the
feature/tvf
branch
from
368c944 to
6c17825
Compare
ingarabr
force-pushed
the
feature/tvf
branch
from
6c17825 to
1b1da5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://cloud.google.com/bigquery/docs/table-functions
This is a breaking change because we have moved UDF under
Routine. I think that's a reasonable thing to do since it aligns the concepts up with how google has defined them. For instance we reuse the syntax forBQSqlFrag.Calland the syntax for calling the routines.