Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of bigquery-http4s #255

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Implementation of bigquery-http4s #255

merged 10 commits into from
Mar 19, 2024

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Jan 18, 2024

Implements Http4s client

This now works with http4s-netty-client, so you should add that as a dependency when using bigquery-http4s

project/plugins.sbt Outdated Show resolved Hide resolved
@hamnis hamnis force-pushed the multiple-clients branch 3 times, most recently from d4b4ff4 to 4a3b340 Compare February 14, 2024 11:59
@hamnis hamnis force-pushed the multiple-clients branch 2 times, most recently from 5e22ab7 to daaa498 Compare February 22, 2024 12:52
hamnis added a commit that referenced this pull request Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which
sbt-typelevel automatically adds.

Now we keep the Scala 2 and Scala 3 versions consistent and
do not confuse intellij which actually respects the -Xsource:3 flag.

Extracted from #255
hamnis added a commit that referenced this pull request Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which
sbt-typelevel automatically adds.

Now we keep the Scala 2 and Scala 3 versions consistent and
do not confuse intellij which actually respects the -Xsource:3 flag.

Extracted from #255
hamnis added a commit that referenced this pull request Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which
sbt-typelevel automatically adds.

Now we keep the Scala 2 and Scala 3 versions consistent and
do not confuse intellij which actually respects the -Xsource:3 flag.

Extracted from #255
hamnis added a commit that referenced this pull request Feb 23, 2024
We should only consider our types when determining update operations

Extract RoutineHelper
Extract TableHelper

Partially backported from #255
Depends on #274
@hamnis hamnis mentioned this pull request Feb 23, 2024
hamnis added a commit that referenced this pull request Feb 23, 2024
We should only consider our types when determining update operations

Extract RoutineHelper
Extract TableHelper

Partially backported from #255
Depends on #274
hamnis added a commit that referenced this pull request Feb 26, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which
sbt-typelevel automatically adds.

Now we keep the Scala 2 and Scala 3 versions consistent and
do not confuse intellij which actually respects the -Xsource:3 flag.

Extracted from #255
hamnis added a commit that referenced this pull request Feb 26, 2024
We should only consider our types when determining update operations

Extract RoutineHelper
Extract TableHelper

Partially backported from #255
Depends on #274
@hamnis hamnis changed the base branch from main to ensure-updated February 26, 2024 07:40
Base automatically changed from ensure-updated to main February 26, 2024 12:37
@hamnis hamnis changed the title Work in progress: Implement pure http4s client Work in progress: Allow multiple implementations of bigquery clients Feb 26, 2024
@hamnis hamnis mentioned this pull request Mar 1, 2024
@hamnis hamnis force-pushed the multiple-clients branch from 6d0e8fc to 84f77e6 Compare March 1, 2024 09:44
@hamnis hamnis changed the base branch from main to google-client March 1, 2024 09:44
@hamnis hamnis force-pushed the multiple-clients branch from 84f77e6 to 41bf288 Compare March 1, 2024 09:47
build.sbt Outdated Show resolved Hide resolved
@hamnis hamnis force-pushed the multiple-clients branch from 978e0d9 to 7bb658a Compare March 4, 2024 07:27
@hamnis hamnis force-pushed the multiple-clients branch from 7bb658a to 9eb06f6 Compare March 4, 2024 07:31
@hamnis hamnis force-pushed the multiple-clients branch 3 times, most recently from a0c5b8f to 0ef1e96 Compare March 4, 2024 07:45
Base automatically changed from google-client to main March 5, 2024 07:13
@hamnis hamnis force-pushed the multiple-clients branch from 0ef1e96 to 5c0a9f6 Compare March 5, 2024 07:47
@hamnis hamnis changed the title Work in progress: Allow multiple implementations of bigquery clients Implementations of bigquery-http4s Mar 5, 2024
@hamnis hamnis changed the title Implementations of bigquery-http4s Implementation of bigquery-http4s Mar 5, 2024
@hamnis hamnis force-pushed the multiple-clients branch from 6314ca6 to dc44445 Compare March 12, 2024 12:29
@hamnis hamnis marked this pull request as ready for review March 12, 2024 12:51
"org.typelevel" %% "munit-cats-effect-3" % "1.0.7" % Test,
("io.chrisdavenport" %% "http4s-grpc-google-cloud-bigquerystorage-v1" % "3.0.0+0.0.6")
.exclude("io.chrisdavenport", s"http4s-grpc_${binaryVersion}"),
("io.chrisdavenport" %% "http4s-grpc" % "0.0.4")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has now been moved to the http4s organization. We should get a new release of that before merge

hamnis added 10 commits March 19, 2024 08:41
* Use googleapis-http4s generated code
Exit after N retries, where N is set to 5 for now.
Remove id from BQPoll.FromJob trait, it is not useful
* Fix TableHelper.toTableReference, the params where in the wrong order
* Downgrade logback to a version that targets slf4j 1.7
* Google rpc client uses the wrong base uri for the resumable upload job
Set http/2 version
@hamnis hamnis force-pushed the multiple-clients branch from 12012a4 to e081f11 Compare March 19, 2024 07:45
@hamnis hamnis merged commit 9bf7a7a into main Mar 19, 2024
9 checks passed
@hamnis hamnis deleted the multiple-clients branch March 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants