-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of bigquery-http4s #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
commented
Jan 24, 2024
hamnis
force-pushed
the
multiple-clients
branch
3 times, most recently
from
February 14, 2024 11:59
d4b4ff4
to
4a3b340
Compare
hamnis
force-pushed
the
multiple-clients
branch
2 times, most recently
from
February 22, 2024 12:52
5e22ab7
to
daaa498
Compare
hamnis
added a commit
that referenced
this pull request
Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which sbt-typelevel automatically adds. Now we keep the Scala 2 and Scala 3 versions consistent and do not confuse intellij which actually respects the -Xsource:3 flag. Extracted from #255
hamnis
added a commit
that referenced
this pull request
Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which sbt-typelevel automatically adds. Now we keep the Scala 2 and Scala 3 versions consistent and do not confuse intellij which actually respects the -Xsource:3 flag. Extracted from #255
hamnis
added a commit
that referenced
this pull request
Feb 23, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which sbt-typelevel automatically adds. Now we keep the Scala 2 and Scala 3 versions consistent and do not confuse intellij which actually respects the -Xsource:3 flag. Extracted from #255
Merged
hamnis
force-pushed
the
multiple-clients
branch
from
February 23, 2024 16:15
1196ab0
to
5bc215d
Compare
hamnis
added a commit
that referenced
this pull request
Feb 26, 2024
This is supported scala 2 synatax as well now with -Xsource:3 which sbt-typelevel automatically adds. Now we keep the Scala 2 and Scala 3 versions consistent and do not confuse intellij which actually respects the -Xsource:3 flag. Extracted from #255
hamnis
force-pushed
the
multiple-clients
branch
from
February 26, 2024 07:44
5bc215d
to
e1c67b6
Compare
hamnis
force-pushed
the
multiple-clients
branch
from
February 26, 2024 12:38
e1c67b6
to
0121c67
Compare
hamnis
changed the title
Work in progress: Implement pure http4s client
Work in progress: Allow multiple implementations of bigquery clients
Feb 26, 2024
hamnis
force-pushed
the
multiple-clients
branch
from
February 28, 2024 09:05
9a6c96b
to
5c6ac44
Compare
hamnis
commented
Mar 1, 2024
hamnis
commented
Mar 1, 2024
hamnis
commented
Mar 1, 2024
Merged
hamnis
commented
Mar 1, 2024
hamnis
force-pushed
the
multiple-clients
branch
3 times, most recently
from
March 4, 2024 07:45
a0c5b8f
to
0ef1e96
Compare
hamnis
changed the title
Work in progress: Allow multiple implementations of bigquery clients
Implementations of bigquery-http4s
Mar 5, 2024
hamnis
changed the title
Implementations of bigquery-http4s
Implementation of bigquery-http4s
Mar 5, 2024
hamnis
force-pushed
the
multiple-clients
branch
from
March 12, 2024 12:29
6314ca6
to
dc44445
Compare
hamnis
commented
Mar 12, 2024
"org.typelevel" %% "munit-cats-effect-3" % "1.0.7" % Test, | ||
("io.chrisdavenport" %% "http4s-grpc-google-cloud-bigquerystorage-v1" % "3.0.0+0.0.6") | ||
.exclude("io.chrisdavenport", s"http4s-grpc_${binaryVersion}"), | ||
("io.chrisdavenport" %% "http4s-grpc" % "0.0.4") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has now been moved to the http4s organization. We should get a new release of that before merge
ingarabr
approved these changes
Mar 14, 2024
* Use googleapis-http4s generated code
Exit after N retries, where N is set to 5 for now. Remove id from BQPoll.FromJob trait, it is not useful
* Fix TableHelper.toTableReference, the params where in the wrong order * Downgrade logback to a version that targets slf4j 1.7 * Google rpc client uses the wrong base uri for the resumable upload job
Set http/2 version
hamnis
force-pushed
the
multiple-clients
branch
from
March 19, 2024 07:45
12012a4
to
e081f11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Http4s client
This now works with http4s-netty-client, so you should add that as a dependency when using bigquery-http4s