-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/feat: 'Next' and 'Queued' segment API #1048
Merged
Julusian
merged 8 commits into
nrkno:release50
from
tv2norge-collab:feat/EAV-24/allow-setting-segment-as-next
Oct 9, 2023
Merged
refactor/feat: 'Next' and 'Queued' segment API #1048
Julusian
merged 8 commits into
nrkno:release50
from
tv2norge-collab:feat/EAV-24/allow-setting-segment-as-next
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectively setting its first part as next, as opposed to queuing until after the current segment
just for consistency
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release50 #1048 +/- ##
=============================================
+ Coverage 58.06% 58.10% +0.03%
=============================================
Files 479 479
Lines 78378 78647 +269
Branches 4093 4120 +27
=============================================
+ Hits 45510 45696 +186
- Misses 32808 32892 +84
+ Partials 60 59 -1
☔ View full report in Codecov by Sentry. |
Note: The author of the original stable API PR has been consulted and they approve of this change. |
Julusian
approved these changes
Oct 9, 2023
ianshade
added a commit
to tv2norge-collab/sofie-core
that referenced
this pull request
Oct 17, 2023
jesperstarkar
added
the
Contribution from TV 2 Norge
Contributions sponsored by TV 2 Norge (tv2.no)
label
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Contribution from TV 2 Norge
Contributions sponsored by TV 2 Norge (tv2.no)
Contribution
External contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is being opened on behalf of TV 2 Norge.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor that includes an addition and a change to the internal UserAction API, and to an endpoint of the HTTP API introduced in this release (release50), therefore not considered breaking.
What is the current behavior? (You can also link to an open issue here)
The currently existing
setNextSegment
action makes it possible to queue a segment, so that its first part will be set as Next when reaching the end of the current segment. There's no endpoint or UserAction available to set the first part of a given segment as Next.What is the new behavior (if this is a feature change)?
setNextSegment
UserAction and the corresponding/playlists/{playlistId}/set-next-segment
endpoint set the first playable part of the given segment as Next. - This corresponds to what has been known in the GUI as Set segment as Next.queueNextSegment
UserAction and the corresponding/playlists/{playlistId}/queue-next-segment
endpoint queue the given segment, so that its first part will be set as Next when reaching the end of the current segment. However, if the next part is already outside of the current segment, the first playable part of the given segment will be set as Next. - This corresponds to what has been known in the GUI as Queue segment.Other information:
The GUI has been updated to use the updated user actions. The
nextSegmentId
property of the Playlist has been renamed toqueuedSegmentId
for consistency.Status