-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #1362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1362 +/- ##
==========================================
Coverage 56.45% 56.46%
==========================================
Files 401 401
Lines 72269 72257 -12
Branches 4583 4586 +3
==========================================
- Hits 40803 40798 -5
+ Misses 31330 31323 -7
Partials 136 136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added one question for a single line that may or may not be excluded from the PR.
…endencies # Conflicts: # meteor/package.json # meteor/yarn.lock # packages/meteor-lib/package.json # packages/mos-gateway/package.json # packages/shared-lib/package.json # packages/webui/package.json # packages/yarn.lock
chore: update dependencies # Conflicts: # packages/webui/package.json # packages/yarn.lock
About the Contributor
This pull request is posted on behalf of the BBC
Type of Contribution
This is a: Code improvement
New Behavior
This is a large round of dependency updates.
Some 'big' changes:
eventemitter3
uses with builtin typed eventemitterMany of these tasks have been put off for a while as they needed nodejs newer than v14, so has been blocked until the meteor update last year.
Everything appears to be working fine, I haven't stressed it much though.
Testing
Affected areas
Time Frame
Other Information
Status