Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #1362

Merged
merged 17 commits into from
Feb 4, 2025
Merged

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Code improvement

New Behavior

This is a large round of dependency updates.

Some 'big' changes:

  • Update yarn to v4
  • Update lerna to latest
  • Update typescript to v5.1 (there is a peer dependency warning, but it is happy. Going further is coming later)
  • Update everything minor/patch versions
  • Various react/ui libraries have not been touched, as I do not have confidence doing so won't involve numerous code changes
  • Replace eventemitter3 uses with builtin typed eventemitter

Many of these tasks have been put off for a while as they needed nodejs newer than v14, so has been blocked until the meteor update last year.

Everything appears to be working fine, I haven't stressed it much though.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Jan 20, 2025
@Julusian Julusian requested a review from a team as a code owner January 20, 2025 14:46
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.46%. Comparing base (d51ba2f) to head (3a7a95a).
Report is 61 commits behind head on release52.

Additional details and impacted files
@@            Coverage Diff             @@
##           release52    #1362   +/-   ##
==========================================
  Coverage      56.45%   56.46%           
==========================================
  Files            401      401           
  Lines          72269    72257   -12     
  Branches        4583     4586    +3     
==========================================
- Hits           40803    40798    -5     
+ Misses         31330    31323    -7     
  Partials         136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added one question for a single line that may or may not be excluded from the PR.

packages/job-worker/src/playout/adlibJobs.ts Outdated Show resolved Hide resolved
…endencies

# Conflicts:
#	meteor/package.json
#	meteor/yarn.lock
#	packages/meteor-lib/package.json
#	packages/mos-gateway/package.json
#	packages/shared-lib/package.json
#	packages/webui/package.json
#	packages/yarn.lock
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
nytamin added a commit that referenced this pull request Feb 4, 2025
chore: update dependencies

# Conflicts:
#	packages/webui/package.json
#	packages/yarn.lock
@nytamin nytamin merged commit f46056a into nrkno:release52 Feb 4, 2025
33 of 34 checks passed
@Julusian Julusian deleted the upstream/update-dependencies branch February 4, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants