fix(core): remove windowsHide from executor calls where we need the c…

…trl + c handler
nrwl · Oct 15, 2024 · 43d01c3 · 43d01c3
1 parent e0f9a5c
commit 43d01c3
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 7 deletions.
diff --git a/packages/js/src/executors/release-publish/release-publish.impl.ts b/packages/js/src/executors/release-publish/release-publish.impl.ts
@@ -128,7 +128,6 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
         env: processEnv(true),
         cwd: context.root,
         stdio: ['ignore', 'pipe', 'pipe'],
-        windowsHide: true,
       });
 
       const resultJson = JSON.parse(result.toString());
@@ -154,7 +153,6 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
               env: processEnv(true),
               cwd: context.root,
               stdio: 'ignore',
-              windowsHide: true,
             });
             console.log(
               `Added the dist-tag ${tag} to v${currentVersion} for registry ${registry}.\n`
@@ -269,7 +267,6 @@ Please update the local dependency on "${depName}" to be a valid semantic versio
       env: processEnv(true),
       cwd: context.root,
       stdio: ['ignore', 'pipe', 'pipe'],
-      windowsHide: true,
     });
 
     /**

diff --git a/packages/nx/src/executors/run-commands/run-commands.impl.ts b/packages/nx/src/executors/run-commands/run-commands.impl.ts
@@ -392,7 +392,6 @@ function nodeProcess(
       maxBuffer: LARGE_BUFFER,
       env,
       cwd,
-      windowsHide: true,
     });
 
     childProcesses.add(childProcess);

diff --git a/packages/nx/src/executors/run-script/run-script.impl.ts b/packages/nx/src/executors/run-script/run-script.impl.ts
@@ -54,7 +54,6 @@ function nodeProcess(
     stdio: ['inherit', 'inherit', 'inherit'],
     cwd,
     env,
-    windowsHide: true,
   });
 }
 

diff --git a/packages/playwright/src/executors/playwright/playwright.impl.ts b/packages/playwright/src/executors/playwright/playwright.impl.ts
@@ -81,7 +81,6 @@ export async function playwrightExecutor(
     execSync(`${pmc.exec} playwright install`, {
       cwd: workspaceRoot,
       stdio: 'inherit',
-      windowsHide: true,
     });
   }
 

diff --git a/packages/web/src/executors/file-server/file-server.impl.ts b/packages/web/src/executors/file-server/file-server.impl.ts
@@ -172,7 +172,6 @@ export default async function* fileServerExecutor(
           execFileSync(pmCmd, args, {
             stdio: [0, 1, 2],
             shell: true,
-            windowsHide: true,
           });
         } catch {
           throw new Error(
-Original file line number
+Diff line change
@@ Expand Up / @@ -392,7 +392,6 @@ function nodeProcess( @@
           maxBuffer: LARGE_BUFFER,
           env,
           cwd,
-          windowsHide: true,
         });
         childProcesses.add(childProcess);
@@ Expand Down @@