Skip to content

Commit

Permalink
fix(js): update minimum supported typescript version by js plugin (#2…
Browse files Browse the repository at this point in the history
  • Loading branch information
leosvelperez authored Dec 1, 2023
1 parent 68d0f79 commit 4926668
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/js/src/generators/init/init.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@ describe('js init generator', () => {

it('should not overwrite installed typescript version when is a supported version', async () => {
updateJson(tree, 'package.json', (json) => {
json.devDependencies = { ...json.devDependencies, typescript: '~4.7.0' };
json.devDependencies = { ...json.devDependencies, typescript: '~4.8.2' };
return json;
});

await init(tree, {});

const packageJson = readJson(tree, 'package.json');
expect(packageJson.devDependencies['typescript']).toBe('~4.7.0');
expect(packageJson.devDependencies['typescript']).toBe('~4.8.2');
expect(packageJson.devDependencies['typescript']).not.toBe(
typescriptVersion
);
Expand Down
2 changes: 1 addition & 1 deletion packages/js/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ export const typescriptVersion = '~5.2.2';
* that's supported by the lowest Angular supported version, e.g.
* `npm view @angular/[email protected] peerDependencies.typescript`
*/
export const supportedTypescriptVersions = '>=4.6.2';
export const supportedTypescriptVersions = '>=4.8.2';

0 comments on commit 4926668

Please sign in to comment.