Skip to content

Commit

Permalink
cleanup(misc): remove unused migrations (#28591)
Browse files Browse the repository at this point in the history
This PR removes migrations that are unused in our packages.

Other changes:

- Update the `remove-migrations` generator to remove all files inside
the migration directory, rather than just the implementation, spec file,
and `__snapshots__` directory. There were some helpers that were not
removed due to this problem.
- Add a check to the `assertValidMigrationPaths` test util (used in
`migrations.spec.ts` test files) to ensure that all paths inside
`./src/migrations` are included in `migrations.json` file. There were a
few migrations missing in the `@nx/expo` package, and we never run them
nor cleaned them up.


**Note:** This has no effect on users and is purely a clean-up.

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
jaysoo committed Oct 23, 2024
1 parent a4f7b96 commit 5da14f4
Show file tree
Hide file tree
Showing 64 changed files with 114 additions and 6,854 deletions.
1 change: 1 addition & 0 deletions packages/angular/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
"prettier",
"typescript",
// These are installed by generators
"@schematics/angular",
"@angular-devkit/core",
"@angular-devkit/architect",
"@angular-devkit/build-angular",
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 5da14f4

Please sign in to comment.