Skip to content

Commit

Permalink
fix(rspack): withModuleFederationForSSR should use commonjs-module as…
Browse files Browse the repository at this point in the history
… library (#28944)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
When navigating directly to a route that renders a portion of a remote
app, SSR was not correctly server rendering the remote portion.
This was because of the output type provided to rspack and MFP

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure commonjs-module is set as output type for MF with SSR

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
Coly010 authored and nartc committed Nov 15, 2024
1 parent 31842f6 commit 90bafc5
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export async function withModuleFederationForSSR(
return (config, { context }: NxRspackExecutionContext) => {
config.target = 'async-node';
config.output.uniqueName = options.name;
config.output.library = {
type: 'commonjs-module',
};
config.optimization = {
...(config.optimization ?? {}),
runtimeChunk: false,
Expand All @@ -39,6 +42,10 @@ export async function withModuleFederationForSSR(
...sharedDependencies,
},
isServer: true,
library: {
type: 'commonjs-module',
},
remoteType: 'script',
/**
* Apply user-defined config overrides
*/
Expand Down

0 comments on commit 90bafc5

Please sign in to comment.