Skip to content

Commit

Permalink
fix(core): daemon spinner should show text (#29448)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Daemon spinner doesn't show up

## Expected Behavior
Daemon spinner shows properly

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
AgentEnder authored Dec 20, 2024
1 parent 81c66ec commit d7ffba8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/nx/src/utils/delayed-spinner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ export class DelayedSpinner {
this.timeouts.push(
setTimeout(() => {
this.ready = true;
this.lastMessage = message;
if (!SHOULD_SHOW_SPINNERS) {
console.warn(this.lastMessage);
} else {
this.spinner = ora(this.lastMessage).start();
}
this.lastMessage = message;
}, delay).unref()
);
}
Expand Down

0 comments on commit d7ffba8

Please sign in to comment.