feat(core): prune lock file based on projects dependencies and package.json #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
changed the title
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
74ee127 to
b97de64
Compare
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
b97de64 to
a46c18e
Compare
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
ee40b54 to
788a9b9
Compare
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
30abb0e to
03c0164
Compare
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
cc7642a to
075ba62
Compare
meeroslav
changed the title
FrozenPandaz
requested changes
Dec 7, 2022
| } | ||
|
|
||
| const packageJson = createPackageJson(projectName, projectGraph, {}); | ||
| // cleanup irrelevant fields from the generated pacakge.json |
There was a problem hiding this comment.
Suggested change
| // cleanup irrelevant fields from the generated pacakge.json | |
| // cleanup irrelevant fields from the generated package.json |
packages/nx/src/lock-file/npm.ts
Outdated
| { | ||
| path: `node_modules/${packageName}`, | ||
| ...(dev ? { dev } : {}), | ||
| ...(optional ? { dev } : {}), |
There was a problem hiding this comment.
This should be optional
…nc in lock file tools
meeroslav
force-pushed
the
prune-project-lock-file
branch
from
bd196b3 to
1f867fc
Compare
meeroslav
commented
Dec 7, 2022
| @@ -33,7 +33,6 @@ export function parseYarnLockFile(lockFile: string): LockFileData { | |||
| isBerry | |||
| ); | |||
| const hash = hashString(lockFile); | |||
| const [mappedPackages, workspacePackages] = mapPackages(dependencies); | |||
There was a problem hiding this comment.
This is a rebase misshap - there were never two instances of this call, otherwise the build would have been failing
FrozenPandaz
approved these changes
Dec 8, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Closes #9761