Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Adding a yarn berry version of isRootVersion utility #14321

Closed
wants to merge 3 commits into from

Conversation

sushruth
Copy link
Contributor

This is a rewritten version of the fix in #14260 with a better approach. Also, to retrigger Circle CI which was not triggering for some reason.

Current Behavior

Building a publishable package fails when

  1. Yarn berry or higher is used as the package manager
  2. More than one version of a package is found in dependencies.

Expected Behavior

Building publishable packages in above-mentioned scenarios must not fail by default.

Related Issue(s)

Fixes #14106 in yarn berry environments

@vercel
Copy link

vercel bot commented Jan 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 9:03PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7a16543. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


⌛ The following targets are in progress

🟥 Failed Commands
nx affected -t test lint --base=fd1c70405527bf871c6e1a62fd71452d024cde83 --head=7a16543f0c66c735bf8c842027b9817977292012 --parallel=1
✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@sushruth
Copy link
Contributor Author

I realize this is actually being dealt with in a very good way here #13864 so I am closing this one. Waiting for it to finish!

@sushruth sushruth closed this Jan 12, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application build failing after upgrade to 15.4.2
2 participants