Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): typescript lib schema #27955

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

master96
Copy link
Contributor

Current Behavior

Currently when react native generators are used. They won't exclude .test extension files.

Expected Behavior

React native generators should exclude .test files in tsconfig lib

Related Issue(s)

Fixes #

@master96 master96 requested a review from a team as a code owner September 17, 2024 14:55
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 10:04pm

@xiongemi xiongemi force-pushed the RN-type-fixed-patch branch from aafb2f1 to 5b237ce Compare December 2, 2024 21:29
@xiongemi xiongemi changed the title RN Fixed typescript lib schema to exclude .test files fix(react-native): typescript lib schema Dec 2, 2024
@xiongemi xiongemi force-pushed the RN-type-fixed-patch branch 2 times, most recently from 491452b to b8c912d Compare December 2, 2024 22:31
@xiongemi xiongemi force-pushed the RN-type-fixed-patch branch 4 times, most recently from f41526a to 89e5270 Compare December 9, 2024 20:49
@xiongemi xiongemi force-pushed the RN-type-fixed-patch branch from 89e5270 to a414f81 Compare December 9, 2024 22:02
@xiongemi xiongemi merged commit 2d135f9 into nrwl:master Dec 10, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
Currently when react native generators are used. They won't exclude
`.test` extension files.

## Expected Behavior
React native generators should exclude `.test` files in tsconfig lib

## Related Issue(s)

Fixes #

Co-authored-by: vivek ajage <[email protected]>
(cherry picked from commit 2d135f9)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants