Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(expo): replace fs-extra with node:fs #28117

Merged
merged 5 commits into from
Sep 27, 2024
Merged

cleanup(expo): replace fs-extra with node:fs #28117

merged 5 commits into from
Sep 27, 2024

Conversation

pralkarz
Copy link
Contributor

See: #27932. fs-extra is mostly unnecessary in projects that only support modern Node versions, and can be replaced with native APIs.

Current Behavior

fs-extra is used.

Expected Behavior

node:fs is used.

Related Issue(s)

N/A

@pralkarz pralkarz requested review from a team as code owners September 25, 2024 22:39
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 26, 2024 0:25am

@pralkarz
Copy link
Contributor Author

@JamesHenry I can't seem to be able to ask people for review manually, so I'm pinging you in since you helped land the other similar PRs. 😄

@JamesHenry JamesHenry merged commit 56eabff into nrwl:master Sep 27, 2024
6 checks passed
@pralkarz pralkarz deleted the expo-remove-fs-extra branch September 27, 2024 09:18
FrozenPandaz pushed a commit that referenced this pull request Sep 27, 2024
Copy link

github-actions bot commented Oct 3, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants