Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove windowsHide from executor calls where we need the ctrl + c handler #28453

Closed
wants to merge 2 commits into from

Conversation

MaxKless
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@MaxKless MaxKless requested review from a team as code owners October 15, 2024 18:00
@MaxKless MaxKless requested a review from Cammisuli October 15, 2024 18:00
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 9:29am

@MaxKless MaxKless requested a review from jaysoo October 15, 2024 18:00
Copy link

Failed to publish a PR release of this pull request, triggered by @MaxKless.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/11362808280

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-28453-54fa63c
Release details 📑
Published version 0.0.0-pr-28453-54fa63c
Triggered by @MaxKless
Branch windowshide-executors-ctrlx
Commit 54fa63c
Workflow run 11363094911

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@MaxKless MaxKless closed this Oct 17, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant