Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure plan subcommand works with object config #28460

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Oct 15, 2024

Current Behavior

The plan command explicitly checks for true, which might not be the case when version plans are enabled.

Expected Behavior

The plan command checks for any truthy value for versionPlans.

Related Issue(s)

Fixes #28387

@JamesHenry JamesHenry requested a review from a team as a code owner October 15, 2024 20:15
@JamesHenry JamesHenry requested a review from AgentEnder October 15, 2024 20:15
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 8:17pm

@JamesHenry JamesHenry enabled auto-merge (squash) October 15, 2024 20:15
@JamesHenry JamesHenry merged commit 3634781 into master Oct 15, 2024
6 checks passed
@JamesHenry JamesHenry deleted the fix-28387 branch October 15, 2024 21:11
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release plan does not work when versionPlans config is an object
2 participants