Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): change tsconfig path on server part #28864

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

yvalentin
Copy link
Contributor

Current Behavior

On a new workspace with nuxt preset (npx create-nx-workspace@latest --preset=nuxt), a tsconfig.json file is create on the nuxt server side directory (path: apps/nuxt-test/src/server/tsconfig.json). The file extends the building nuxt server tsconfig file (path: apps/nuxt-test/.nuxt/tsconfig.server.json) with the following value :

{
  "extends": "../.nuxt/tsconfig.server.json"
}

Expected Behavior

This tconfig.json file generate need to extends the tsconfig.server.json with the good path

Fixes #

The correct value is

{
  "extends": "../../.nuxt/tsconfig.server.json"
}

@yvalentin yvalentin requested a review from a team as a code owner November 9, 2024 20:20
@yvalentin yvalentin requested a review from mandarini November 9, 2024 20:20
Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 8:23pm

@Coly010 Coly010 merged commit 8516634 into nrwl:master Dec 20, 2024
5 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
@yvalentin yvalentin deleted the fix/nuxt-generator-tsconfig-server branch December 27, 2024 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants