fix(js): only add typescript project references for explicit dependencies in sync generator #28998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies in sync generator This change omits references to implicit dependency tsconfigs for typescript projects in the sync generator, since given that they are not referenced directly in code there is no need for project references. Fixes nrwl#28997
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 2bdf541.
☁️ Nx Cloud last updated this comment at |
|
@Coly010 @leosvelperez - Any updates on this one? I am currently blocked on upgrading NX due to this :( |
leosvelperez
requested changes
Dec 16, 2024
…itly referenced in code Co-authored-by: Leosvel Pérez Espinosa <[email protected]>
cogwirrel
force-pushed
the
fix/sync-generator-implicit-deps
branch
from
7f7a544 to
0f4c0bb
Compare
|
Your CI Pipeline Execution ↗ for commit a830aee is in progress ⏳
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Dec 20, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 7, 2025
…cies in sync generator (#28998) This change omits references to implicit dependency tsconfigs for typescript projects in the sync generator, since given that they are not referenced directly in code there is no need for project references. ## Current Behavior TypeScript sync generator adds references to any dependency project which has a tsconfig (where composite is true), including implicit dependencies where these references are unnecessary and can potentially cause build failures. See [example repo](https://github.com/cogwirrel/nx-sync-generator-implicit-deps-example). ## Expected Behavior Only explicit dependencies should be referenced in tsconfigs. ## Related Issue(s) Fixes #28997 --------- Co-authored-by: Leosvel Pérez Espinosa <[email protected]> (cherry picked from commit 9e78142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change omits references to implicit dependency tsconfigs for typescript projects in the sync generator, since given that they are not referenced directly in code there is no need for project references.
Current Behavior
TypeScript sync generator adds references to any dependency project which has a tsconfig (where composite is true), including implicit dependencies where these references are unnecessary and can potentially cause build failures.
See example repo.
Expected Behavior
Only explicit dependencies should be referenced in tsconfigs.
Related Issue(s)
Fixes #28997