Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add missing supported CI providers to NxCloud type #29008

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

tinesoft
Copy link
Contributor

@tinesoft tinesoft commented Nov 20, 2024

Current Behavior

CreateWorkspaceOptions that is exposed via the create-nx-workspace package,

nxCloud: NxCloud; // Enable Nx Cloud

has a field named NxCloud that only contains the following types:,

export type NxCloud = 'yes' | 'github' | 'circleci' | 'skip';

while more CI providers are in fact supported by the underlying code (see NxCloudChoices array in ab-testing.ts):

export const NxCloudChoices = [

Expected Behavior

Align the type of NxCloud to match all supported values from NxCloudChoices

Related Issue(s)

Fixes #

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 3:35pm

@AgentEnder AgentEnder merged commit 60a9f81 into nrwl:master Nov 20, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Nov 22, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants