Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): None buildable libs should not have a build target #29175

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Dec 3, 2024

When using the new useTsSolution option for applications libraries are automatically opted into using a build target even though they may not be buildable.

This change ensures non-buildable libs are excluded from being built.

@ndcunningham ndcunningham added the scope: react Issues related to React support for Nx label Dec 3, 2024
@ndcunningham ndcunningham self-assigned this Dec 3, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner December 3, 2024 22:14
@ndcunningham ndcunningham requested a review from Coly010 December 3, 2024 22:14
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 10:15pm

@ndcunningham ndcunningham merged commit dd14f39 into master Dec 3, 2024
7 checks passed
@ndcunningham ndcunningham deleted the fix/react-lib-none-buildable-exclusion branch December 3, 2024 23:30
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: react Issues related to React support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants