Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): skip changelog generation for projects without available version data #29212

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

thdk
Copy link
Contributor

@thdk thdk commented Dec 5, 2024

Other places in code also check if the project exists in the versionData object before accessing its properties.

Fixes #29211

@thdk thdk requested a review from a team as a code owner December 5, 2024 09:12
@thdk thdk requested a review from FrozenPandaz December 5, 2024 09:12
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 9:14am

@thdk thdk changed the title Don't fail changelog generation for projects without version data fix(release): skip changelog generation for projects without available version data Dec 5, 2024
@JamesHenry JamesHenry merged commit b848bb3 into nrwl:master Dec 5, 2024
6 checks passed
@JamesHenry
Copy link
Collaborator

Thanks @thdk!

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate changelog for projects fails with Cannot read properties of undefined (reading 'newVersion')
2 participants