Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add migration to remove the tailwindConfig option from ng-packager executors #29220

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

leosvelperez
Copy link
Member

Add migration to remove the tailwindConfig option from the ng-packagr executors, which have been unused since Angular v17. Tailwind CSS configurations located at the project or workspace root will be picked up automatically.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #29217

@leosvelperez leosvelperez requested a review from Coly010 December 5, 2024 14:46
@leosvelperez leosvelperez self-assigned this Dec 5, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner December 5, 2024 14:46
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2024 2:47pm

@leosvelperez leosvelperez merged commit 625d8f3 into master Dec 5, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/migration-remove-tailwind-config branch December 5, 2024 15:18
bcabanes pushed a commit to bcabanes/nx that referenced this pull request Dec 5, 2024
…om ng-packager executors (nrwl#29220)

Add migration to remove the `tailwindConfig` option from the ng-packagr
executors, which have been unused since Angular v17. Tailwind CSS
configurations located at the project or workspace root will be picked
up automatically.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes nrwl#29217
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20.2.0-beta.7 didn't remove tailwindConfig option from the ng-packagr executors
2 participants