Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): make commits separator in git log command more unique #29261

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

The commits separator ---- used for the git log formatting behind the scenes could potentially appear in the commit body and is not unique enough.

Expected Behavior

We use a separator of |@-------@| which is extremely unlikely to appear organically in a commit message.

Related Issue(s)

Fixes #26241

@JamesHenry JamesHenry requested a review from a team as a code owner December 9, 2024 13:21
@JamesHenry JamesHenry requested a review from xiongemi December 9, 2024 13:21
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Dec 9, 2024 1:21pm

@JamesHenry JamesHenry enabled auto-merge (squash) December 9, 2024 13:26
@JamesHenry JamesHenry merged commit 2c07bf0 into master Dec 9, 2024
6 checks passed
@JamesHenry JamesHenry deleted the release-commit-sep branch December 9, 2024 19:43
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants